Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing stream, mr arguments at libcudf column creation #7779

Merged

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Mar 31, 2021

Follow up on PR #7769
This PR fixes few more places of missing stream, and memory resource arguments.

@karthikeyann karthikeyann requested a review from a team as a code owner March 31, 2021 13:09
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 31, 2021
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change tech debt labels Mar 31, 2021
@ttnghia
Copy link
Contributor

ttnghia commented Apr 1, 2021

Rerun tests.

@harrism
Copy link
Member

harrism commented Apr 1, 2021

This PR was opened during burndown, so should probably target 0.20. Is this urgent @karthikeyann ?

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #7779 (95b9aac) into branch-0.20 (599f62d) will increase coverage by 0.42%.
The diff coverage is 88.73%.

❗ Current head 95b9aac differs from pull request most recent head 1810f8e. Consider uploading reports for the commit 1810f8e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7779      +/-   ##
===============================================
+ Coverage        82.30%   82.72%   +0.42%     
===============================================
  Files              101      103       +2     
  Lines            17053    17705     +652     
===============================================
+ Hits             14035    14647     +612     
- Misses            3018     3058      +40     
Impacted Files Coverage Δ
python/cudf/cudf/utils/utils.py 83.25% <ø> (-1.81%) ⬇️
python/cudf/cudf/utils/dtypes.py 83.44% <46.66%> (-6.45%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <78.57%> (-1.04%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <80.00%> (+0.19%) ⬆️
python/dask_cudf/dask_cudf/backends.py 89.58% <85.71%> (-0.05%) ⬇️
python/cudf/cudf/core/column/struct.py 96.29% <86.66%> (-3.71%) ⬇️
python/cudf/cudf/core/index.py 93.04% <88.09%> (+0.01%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 91.11% <92.30%> (+0.48%) ⬆️
python/cudf/cudf/core/column/column.py 87.99% <92.59%> (+0.56%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c1c9e...1810f8e. Read the comment docs.

@karthikeyann
Copy link
Contributor Author

Not urgent. Changes are same as #7769

@karthikeyann karthikeyann changed the base branch from branch-0.19 to branch-0.20 April 5, 2021 11:18
@karthikeyann
Copy link
Contributor Author

rerun tests

1 similar comment
@karthikeyann
Copy link
Contributor Author

rerun tests

@karthikeyann karthikeyann removed the 3 - Ready for Review Ready for review by team label Apr 9, 2021
@karthikeyann karthikeyann self-assigned this Apr 9, 2021
@karthikeyann karthikeyann added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 9, 2021
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7ad07b4 into rapidsai:branch-0.20 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants