User resource fix for replace_nulls #7769
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
approved these changes
Mar 30, 2021
hyperbolic2346
approved these changes
Mar 30, 2021
ttnghia
approved these changes
Mar 31, 2021
|
Rerun tests. |
rgsl888prabhu
approved these changes
Mar 31, 2021
karthikeyann
approved these changes
Mar 31, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7769 +/- ##
===============================================
+ Coverage 81.86% 82.65% +0.78%
===============================================
Files 101 103 +2
Lines 16884 17524 +640
===============================================
+ Hits 13822 14484 +662
+ Misses 3062 3040 -22
Continue to review full report at Codecov.
|
|
@magnatelee can you look at the CI failures? |
error is unrelated. I think a CI hiccup that ops is actively dealing with. |
|
rerun tests |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2021
Follow up on PR #7769 This PR fixes few more places of missing stream, and memory resource arguments. Authors: - Karthikeyan (https://github.com/karthikeyann) Approvers: - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu) - Nghia Truong (https://github.com/ttnghia) URL: #7779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cudf::replace_nullswas copying the input column with the default stream and resource when there is no null. This simple PR is to make sure to pass the right stream and resource to the copy constructor.