Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused JVM array creation [skip ci] #7748

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 29, 2021

The JNI method to build a column from Arrow creates a Java array but then doesn't use it. This removes the unnecessary JVM callback and object creation.

@jlowe jlowe added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 29, 2021
@jlowe jlowe self-assigned this Mar 29, 2021
@jlowe jlowe requested a review from a team as a code owner March 29, 2021 13:31
@jlowe
Copy link
Member Author

jlowe commented Mar 29, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 213b7f5 into rapidsai:branch-0.19 Mar 29, 2021
@jlowe jlowe deleted the jni-remove-unused-array branch September 10, 2021 15:46
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants