Skip to content

Commit

Permalink
Remove unused JVM array creation (#7748)
Browse files Browse the repository at this point in the history
The JNI method to build a column from Arrow creates a Java array but then doesn't use it.  This removes the unnecessary JVM callback and object creation.

Authors:
  - Jason Lowe (@jlowe)

Approvers:
  - Robert (Bobby) Evans (@revans2)

URL: #7748
  • Loading branch information
jlowe authored Mar 29, 2021
1 parent cddafd9 commit 213b7f5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion java/src/main/native/src/ColumnVectorJni.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnVector_fromArrow(JNIEnv *env,
auto null_buffer = arrow::Buffer::Wrap(static_cast<const char *>(validity_address), static_cast<int>(validity_length));
auto offsets_buffer = arrow::Buffer::Wrap(static_cast<const char *>(offsets_address), static_cast<int>(offsets_length));

cudf::jni::native_jlongArray outcol_handles(env, 1);
std::shared_ptr<arrow::Array> arrow_array;
switch (n_type) {
case cudf::type_id::DECIMAL32:
Expand Down

0 comments on commit 213b7f5

Please sign in to comment.