Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dask dispatch to cuDF's is_categorical_dtype for cuDF objects #7740

Merged
merged 6 commits into from
Mar 30, 2021
Merged

Enable dask dispatch to cuDF's is_categorical_dtype for cuDF objects #7740

merged 6 commits into from
Mar 30, 2021

Conversation

brandon-b-miller
Copy link
Contributor

Fixes #7111
Closes #7400

@brandon-b-miller brandon-b-miller added bug Something isn't working 2 - In Progress Currently a work in progress Python Affects Python cuDF API. dask Dask issue 4 - Needs Dask Reviewer non-breaking Non-breaking change labels Mar 26, 2021
@brandon-b-miller brandon-b-miller self-assigned this Mar 26, 2021
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 26, 2021 18:21
kkraus14
kkraus14 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test in the dask-cudf unit tests for the get_dummies method which tests this?

@kkraus14 kkraus14 mentioned this pull request Mar 26, 2021
Merged
3 tasks
@kkraus14
Copy link
Collaborator

We'll also need to bump the required Dask version here

@kkraus14
Copy link
Collaborator

rerun tests

@codecov
Copy link

codecov bot commented Mar 26, 2021 •
edited
Loading

Codecov Report

Merging #7740 (d903ce7) into branch-0.19 (7871e7a) will increase coverage by 0.43%.
The diff coverage is n/a.

❗ Current head d903ce7 differs from pull request most recent head 22ca8f3. Consider uploading reports for the commit 22ca8f3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7740      +/-   ##
===============================================
+ Coverage        81.86%   82.30%   +0.43%     
===============================================
  Files              101      101              
  Lines            16884    17055     +171     
===============================================
+ Hits             13822    14037     +215     
+ Misses            3062     3018      -44
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 87.21% <0.00%> (-4.18%) ⬇️
python/cudf/cudf/core/column/decimal.py 93.84% <0.00%> (-1.03%) ⬇️
python/cudf/cudf/utils/utils.py 85.06% <0.00%> (-0.38%) ⬇️
python/cudf/cudf/core/column/column.py 87.43% <0.00%> (-0.33%) ⬇️
python/cudf/cudf/core/scalar.py 86.91% <0.00%> (-0.19%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
python/cudf/cudf/utils/cudautils.py 50.38% <0.00%> (ø)
python/cudf/cudf/core/tools/datetimes.py 84.44% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 95.02% <0.00%> (ø)
python/cudf/cudf/core/join/casting_logic.py
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d49f75...22ca8f3. Read the comment docs.

@kkraus14
Copy link
Collaborator

Tests look good. Will push a commit bumping the version in the conda recipe and this should be good to go.

kkraus14
kkraus14 reviewed Mar 30, 2021
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
@kkraus14
Copy link
Collaborator

May want to update this as well: https://github.com/rapidsai/integration/blob/branch-0.19/conda/recipes/versions.yaml#L49-L50

@brandon-b-miller
Copy link
Contributor Author

created rapidsai/integration#235

@mike-wendt mike-wendt mentioned this pull request Mar 30, 2021
Merged
@brandon-b-miller
Update ci/gpu/build.sh
d6240ce 
Co-authored-by: Keith Kraus <[email protected]>
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 30, 2021 17:04
@github-actions github-actions bot removed the gpuCI label Mar 30, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress 4 - Needs Dask Reviewer labels Mar 30, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

1 similar comment
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ad9212b into rapidsai:branch-0.19 Mar 30, 2021
@ajschmidt8 ajschmidt8 mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@brandon-b-miller brandon-b-miller

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
4 participants
@brandon-b-miller @kkraus14 @galipremsagar @raydouglass