Fix ORC reader issue with reading empty string columns #7656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgsl888prabhu
added
bug
rgsl888prabhu
requested review from
karthikeyann,
davidwendt,
cwharris and
shwina
github-actions
bot
added
Python
rgsl888prabhu
requested review from
vuule and
devavret
and removed request for
karthikeyann and
davidwendt
devavret
approved these changes
Mar 19, 2021
vuule
approved these changes
Mar 19, 2021
Anyone who's worked on cuIO knows. The issue that took me a month had a 2 line fix. |
Ouch. Do you remember the PR # ? |
I misremember. It was #5473 but it was 16 days. It felt like an eternity though. |
kkraus14
approved these changes
Mar 19, 2021
kkraus14
removed
3 - Ready for Review
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a condition in reader where if the data size is zero, then stream pointer was not getting updated.
But in case of
["", ""]where it is a valid data with 0 size, it was reading it as[null, null], so the condition has been removed which caused this issue.I have also added test cases to validate.
closes #7620