[WIP] Fix orc reader RLEv2 reader #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch bit width is only allowed to be from a fixed set of values. Patch width is to be selected as the smallest value from the set that fit the required patch size (pw + pgw)
Fixes the narrowing conversion in bytestream reading in patched RLE
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
vuule
reviewed
Jun 15, 2020
harrism
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.15 #5473 +/- ##
===============================================
+ Coverage 88.65% 88.77% +0.12%
===============================================
Files 57 57
Lines 10945 11003 +58
===============================================
+ Hits 9703 9768 +65
+ Misses 1242 1235 -7
Continue to review full report at Codecov.
|
OlivierNV
suggested changes
Jun 16, 2020
OlivierNV
approved these changes
Jun 17, 2020
rgsl888prabhu
approved these changes
Jun 22, 2020
|
Great job and thanks for the fix, @devavret |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5440
Fixes #5324
Opened ORC-642 to track issue in apache's docs.