Refactor ConfigureCUDA to not conditionally insert compiler flags #7643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the state of `BUILD_TESTING` or `BUILD_BENCHMARKS` now doesn't cause a recompilation of all cudf source files.
github-actions
bot
added
CMake
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7643 +/- ##
===============================================
+ Coverage 81.86% 82.47% +0.60%
===============================================
Files 101 101
Lines 16884 17394 +510
===============================================
+ Hits 13822 14345 +523
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
robertmaynard
changed the title
harrism
reviewed
Mar 23, 2021
| @@ -29,10 +29,6 @@ enable_language(CUDA) | |||
|
|
|||
| if(CMAKE_COMPILER_IS_GNUCXX) | |||
| list(APPEND CUDF_CXX_FLAGS -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations) | |||
| if(CUDF_BUILD_TESTS OR CUDF_BUILD_BENCHMARKS) | |||
| # Suppress parentheses warning which causes gmock to fail | |||
| list(APPEND CUDF_CUDA_FLAGS -Xcompiler=-Wno-parentheses) | |||
There was a problem hiding this comment.
Is this no-parentheses warning no longer an issue?
There was a problem hiding this comment.
I tested locally with a CPM'd gmock/gtest and had no build failures ( CUDA 11.1 ).
harrism
added
improvement
kkraus14
approved these changes
Mar 23, 2021
harrism
approved these changes
Mar 24, 2021
|
@gpucibot merge |
robertmaynard
deleted the
fix/dont_change_build_options_when_gmock_enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the state of
BUILD_TESTINGorBUILD_BENCHMARKSnow doesn't cause a recompilation of all cudf source files.