Skip to content

Commit

Permalink
Refactor ConfigureCUDA to not conditionally insert compiler flags (#7643
Browse files Browse the repository at this point in the history
)

Changing the state of `BUILD_TESTING` or `BUILD_BENCHMARKS` now doesn't cause a recompilation of all cudf source files.

Authors:
  - Robert Maynard (@robertmaynard)

Approvers:
  - Keith Kraus (@kkraus14)
  - Mark Harris (@harrism)

URL: #7643
  • Loading branch information
robertmaynard authored Mar 24, 2021
1 parent 6ed360c commit 0c36ca9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions cpp/cmake/Modules/ConfigureCUDA.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ enable_language(CUDA)

if(CMAKE_COMPILER_IS_GNUCXX)
list(APPEND CUDF_CXX_FLAGS -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations)
if(CUDF_BUILD_TESTS OR CUDF_BUILD_BENCHMARKS)
# Suppress parentheses warning which causes gmock to fail
list(APPEND CUDF_CUDA_FLAGS -Xcompiler=-Wno-parentheses)
endif()
endif()

list(APPEND CUDF_CUDA_FLAGS --expt-extended-lambda --expt-relaxed-constexpr)
Expand Down

0 comments on commit 0c36ca9

Please sign in to comment.