Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debug build break with device_uvectors in grouped_rolling.cu #7633

Merged
merged 6 commits into from
Mar 21, 2021
Merged

Fix Debug build break with device_uvectors in grouped_rolling.cu #7633

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a2547f0
Fix indexing into device_uvector
mythrocks Mar 17, 2021
4df64b1
Code formatting.
mythrocks Mar 18, 2021
168d2a0
Use available stream instead of default.
mythrocks Mar 18, 2021
8309dad
Merge remote-tracking branch 'origin/branch-0.19' into fix-rolling-wi…
mythrocks Mar 18, 2021
17c951f
Code formatting.
mythrocks Mar 18, 2021
d5c8212
Merge remote-tracking branch 'origin/branch-0.19' into fix-rolling-wi…
mythrocks Mar 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cpp/src/rolling/grouped_rolling.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ std::unique_ptr<column> grouped_rolling_window(table_view const& group_keys,
// groups.)
// 3. [0, 500, 1000] indicates two equal-sized groups: [0,500), and [500,1000).

assert(group_offsets.size() >= 2 && group_offsets[0] == 0 &&
group_offsets[group_offsets.size() - 1] == input.size() &&
assert(group_offsets.size() >= 2 && group_offsets.element(0, rmm::cuda_stream_default) == 0 &&
group_offsets.element(group_offsets.size() - 1, rmm::cuda_stream_default) ==
input.size() &&
mythrocks marked this conversation as resolved.
Show resolved Hide resolved
"Must have at least one group.");

auto preceding_calculator = [d_group_offsets = group_offsets.data(),
Expand Down