-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Debug build break with device_uvectors in grouped_rolling.cu #7633
Fix Debug build break with device_uvectors in grouped_rolling.cu #7633
Conversation
Alternatively, we might just remove the |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7633 +/- ##
===============================================
+ Coverage 81.86% 82.47% +0.60%
===============================================
Files 101 101
Lines 16884 17397 +513
===============================================
+ Hits 13822 14348 +526
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a part of this PR but can you please add the stream to the group_offsets()
and group_labels()
Done. Thanks for pointing that out. TIL. |
@mythrocks Is this good to merge? |
Yikes. Yes, this should be merged. Or should have been. I'd better leave this till I've rebased and retested, in light of recent changes in the code base. |
Rebased and retested. All tests are passing. I'll merge this now. |
@gpucibot merge |
After #7523, on
Debug
builds, one seems to see the following build error:The offending line has an
assert()
that is only compiled duringDebug
builds. This commit corrects the indexing intodevice_uvector
.