Fix auto-detecting GPU architectures #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ARCHITECTURES, fix auto-detecting GPU architecture
github-actions
bot
added
CMake
trxcllnt
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7593 +/- ##
===============================================
+ Coverage 81.98% 82.38% +0.40%
===============================================
Files 101 101
Lines 16989 17350 +361
===============================================
+ Hits 13928 14294 +366
+ Misses 3061 3056 -5
Continue to review full report at Codecov.
|
kkraus14
reviewed
Mar 14, 2021
kkraus14
approved these changes
Mar 15, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2021
After #7593 the variables for controlling the CUDA build for either all architectures or detected architectures changed to be based on the project name which broke the JNI build. This updates the JNI CMakeList accordingly to fix the JNI build. Authors: - Jason Lowe (@jlowe) Approvers: - Rong Ou (@rongou) - Gera Shegalov (@gerashegalov) - Thomas Graves (@tgravescs) URL: #7612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #7579 in auto-detecting GPU architectures when
-DCMAKE_CUDA_ARCHITECTURES=is passed on the CLI.Now that the cached
CMAKE_CUDA_ARCHITECTURESisn't unset before callingenable_language(CUDA), this call throws an error and configuration fails. This change ensures we callenable_language(CUDA)after any potential rewrites ofCMAKE_CUDA_ARCHITECTURES.This PR also aligns with RMM's
EvalGPUArchs.cmakelogic and printsSUPPORTED_CUDA_ARCHITECTURESinstead of"ALL"in the case the current machine is a CPU-only node.Related: rapidsai/rmm#727