Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CMAKE_CUDA_ARCHITECTURES doesn't change when build-system invokes cma…
…ke (#7579) Consider the following: ``` cmake -DCMAKE_CUDA_ARCHITECTURES="" . #build for detected touch <cudf_dir>/cpp/CMakeLists.txt ninja #should be build for detected cmake -DCMAKE_CUDA_ARCHITECTURES= . #build for all touch <cudf_dir>/cpp/CMakeLists.txt ninja #should be build for all cmake -DCMAKE_CUDA_ARCHITECTURES="" . #build for detected touch <cudf_dir>/cpp/CMakeLists.txt ninja #should be build for detected ``` Before these changes the invocations of `ninja` would always go back to building for all when ever `ninja` was invoked. The issue is that once a CMake cache variable exists it can't be removed via `-DCMAKE_CUDA_ARCHITECTURES=` and therefore becomes sticky. To resolve the issue you can now pass `-DCMAKE_CUDA_ARCHITECTURES=ALL` to consistently get all archs, and now the build-system should not change what CUDA archs you are building for. Authors: - Robert Maynard (@robertmaynard) Approvers: - Keith Kraus (@kkraus14) URL: #7579
- Loading branch information