Implement drop_list_duplicates #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
ttnghia
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7528 +/- ##
===============================================
+ Coverage 81.85% 82.38% +0.52%
===============================================
Files 101 101
Lines 16883 17339 +456
===============================================
+ Hits 13819 14284 +465
+ Misses 3064 3055 -9
Continue to review full report at Codecov.
|
davidwendt
reviewed
Mar 8, 2021
davidwendt
reviewed
Mar 8, 2021
davidwendt
requested changes
Mar 10, 2021
…, and fix example in the comments
nvdbaranec
approved these changes
Mar 10, 2021
ttnghia
commented
Mar 10, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
#7551) Fix the `offset_end` iterator in `lists_column_view`. Since the offset column size is one element larger than the number of column rows, the `offset_end` should be computed as `offset_begin() + size() + 1`. This can also be done by `offset_begin() + offsets().size()`. This PR blocks #7528, thus it must be merged before that PR. Authors: - Nghia Truong (@ttnghia) Approvers: - Jake Hemstad (@jrhemstad) - Mike Wilson (@hyperbolic2346) - Vukasin Milovanovic (@vuule) URL: #7551
davidwendt
requested changes
Mar 10, 2021
…t elements, which takes into account the current stream value
davidwendt
reviewed
Mar 11, 2021
davidwendt
approved these changes
Mar 12, 2021
|
@gpucibot merge |
kkraus14
approved these changes
Mar 12, 2021
This was referenced Mar 12, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 23, 2021
This partially addresses #2973. This PR implements groupby `collect_set` aggregation. The idea of this PR is to simply apply `drop_list_duplicates` (#7528) to the result generated by groupby `collect_list`, obtaining collect lists without duplicate entries. Examples: ``` keys = {1, 1, 1, 1, 2, 2, 2, 2, 3, 3, 3, 3}; vals = {10, 11, 10, 10, 20, 21, 21, 20, 30, 33, 32, 31}; keys_output = {1, 2, 3}; vals_output = {{10, 11}, {20, 21}, {30, 31, 32, 33}}; ``` In this PR, a simple, incomplete Python binding for `collect_set` has been added, and no Java binding is implemented yet. Complete bindings for those Python/Java sides need to be implemented later in some other separate PRs. Authors: - Nghia Truong (@ttnghia) Approvers: - AJ Schmidt (@ajschmidt8) - Karthikeyan (@karthikeyann) - Keith Kraus (@kkraus14) - Jason Lowe (@jlowe) - Ashwin Srinath (@shwina) URL: #7420
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
rapidsai#7551) Fix the `offset_end` iterator in `lists_column_view`. Since the offset column size is one element larger than the number of column rows, the `offset_end` should be computed as `offset_begin() + size() + 1`. This can also be done by `offset_begin() + offsets().size()`. This PR blocks rapidsai#7528, thus it must be merged before that PR. Authors: - Nghia Truong (@ttnghia) Approvers: - Jake Hemstad (@jrhemstad) - Mike Wilson (@hyperbolic2346) - Vukasin Milovanovic (@vuule) URL: rapidsai#7551
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
Closes rapidsai#7494 and partially addresses rapidsai#7414. This is the new implementation for `drop_list_duplicates`, which removes duplicated entries from lists column. The result is a new lists column in which each list row contains only unique entries. By current implementation, the output lists will have entries sorted by ascending order (null(s) last). Example with null_equality=EQUAL: ``` input: { {1, 1, 2, 1, 3}, {4}, NULL, {}, {NULL, NULL, NULL, 5, 6, 6, 6, 5} } output: { {1, 2, 3}, {4}, NULL, {}, {5, 6, NULL} } ``` Example with null_equality=UNEQUAL: ``` input: { {1, 1, 2, 1, 3}, {4}, NULL, {}, {NULL, NULL, NULL, 5, 6, 6, 6, 5} } output: { {1, 2, 3}, {4}, NULL, {}, {5, 6, NULL, NULL, NULL} } ``` Authors: - Nghia Truong (@ttnghia) Approvers: - AJ Schmidt (@ajschmidt8) - @nvdbaranec - David (@davidwendt) - Keith Kraus (@kkraus14) URL: rapidsai#7528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7494 and partially addresses #7414.
This is the new implementation for
drop_list_duplicates, which removes duplicated entries from lists column. The result is a new lists column in which each list row contains only unique entries. By current implementation, the output lists will have entries sorted by ascending order (null(s) last).Example with null_equality=EQUAL:
Example with null_equality=UNEQUAL: