Removed unneeded includes from traits.hpp #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
trxcllnt
approved these changes
Mar 3, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7509 +/- ##
===============================================
+ Coverage 81.88% 82.27% +0.39%
===============================================
Files 101 101
Lines 16900 17261 +361
===============================================
+ Hits 13838 14202 +364
+ Misses 3062 3059 -3
Continue to review full report at Codecov.
|
jrhemstad
approved these changes
Mar 11, 2021
|
@gpucibot merge |
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
The `cpp/include/cudf/utilities/traits.hpp` file is parsed when building most libcudf source files (~200). This PR removes a couple unneeded header includes to help reduce the compile dependency. Only a couple files needed to be updated that relied on `traits.hpp` including these for them. Authors: - David (@davidwendt) Approvers: - Paul Taylor (@trxcllnt) - Jake Hemstad (@jrhemstad) URL: rapidsai#7509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cpp/include/cudf/utilities/traits.hppfile is parsed when building most libcudf source files (~200). This PR removes a couple unneeded header includes to help reduce the compile dependency. Only a couple files needed to be updated that relied ontraits.hppincluding these for them.