Skip to content

Commit

Permalink
Removed unneeded includes from traits.hpp (rapidsai#7509)
Browse files Browse the repository at this point in the history
The `cpp/include/cudf/utilities/traits.hpp` file is parsed when building most libcudf source files (~200). This PR removes a couple unneeded header includes to help reduce the compile dependency. Only a couple files needed to be updated that relied on `traits.hpp` including these for them.

Authors:
  - David (@davidwendt)

Approvers:
  - Paul Taylor (@trxcllnt)
  - Jake Hemstad (@jrhemstad)

URL: rapidsai#7509
  • Loading branch information
davidwendt authored and hyperbolic2346 committed Mar 23, 2021
1 parent fa66823 commit d0f6c3c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cpp/include/cudf/utilities/traits.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#pragma once

#include <cudf/lists/list_view.cuh>
#include <cudf/structs/struct_view.hpp>
#include <cudf/types.hpp>
#include <cudf/utilities/type_dispatcher.hpp>
#include <cudf/wrappers/durations.hpp>
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/interop/dlpack.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
#include <cudf/column/column_factories.hpp>
#include <cudf/detail/interop.hpp>
#include <cudf/lists/list_view.cuh>
#include <cudf/structs/struct_view.hpp>
#include <cudf/utilities/error.hpp>
#include <cudf/utilities/type_dispatcher.hpp>

Expand Down
1 change: 1 addition & 0 deletions cpp/src/io/csv/csv_gpu.cu
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <cudf/lists/list_view.cuh>
#include <cudf/null_mask.hpp>
#include <cudf/strings/string_view.cuh>
#include <cudf/structs/struct_view.hpp>
#include <cudf/utilities/bit.hpp>
#include <cudf/utilities/error.hpp>
#include <cudf/utilities/span.hpp>
Expand Down

0 comments on commit d0f6c3c

Please sign in to comment.