Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cudf::binary_operation TRUE_DIV for decimal32 and decimal64 #7198

Merged
merged 21 commits into from
Jan 29, 2021
Merged

Add support for cudf::binary_operation TRUE_DIV for decimal32 and decimal64 #7198

merged 21 commits into from
Jan 29, 2021

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Jan 22, 2021 •
edited
Loading

This resolves a part of #7132

ToDo:

  • Simple unit test
  • Comprehensive unit tests
  • Initial Column + Column
  • Full Column + Column
  • Column + Scalar
  • Scalar + Column
  • Cleanup

@codereport codereport added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jan 22, 2021
@codereport codereport self-assigned this Jan 22, 2021
@codereport codereport mentioned this pull request Jan 22, 2021
Closed
45 tasks
@codecov
Copy link

codecov bot commented Jan 23, 2021 •
edited
Loading

Codecov Report

Merging #7198 (8cfbe11) into branch-0.18 (8860baf) will increase coverage by 0.09%.
The diff coverage is 89.86%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7198      +/-   ##
===============================================
+ Coverage        82.09%   82.19%   +0.09%     
===============================================
  Files               97       99       +2     
  Lines            16474    16813     +339     
===============================================
+ Hits             13524    13819     +295     
- Misses            2950     2994      +44
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 91.57% <ø> (-0.18%) ⬇️
python/cudf/cudf/core/column/string.py 86.56% <ø> (-0.09%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <ø> (ø)
python/cudf/cudf/core/dtypes.py 90.10% <50.00%> (-0.28%) ⬇️
python/cudf/cudf/io/orc.py 86.89% <66.66%> (-1.51%) ⬇️
python/cudf/cudf/core/dataframe.py 90.53% <76.92%> (-0.18%) ⬇️
python/cudf/cudf/io/csv.py 91.66% <86.66%> (-1.67%) ⬇️
python/cudf/cudf/core/reshape.py 91.19% <93.75%> (+0.16%) ⬆️
python/dask_cudf/dask_cudf/io/tests/test_s3.py 95.94% <94.11%> (+0.11%) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c116e3...8cfbe11. Read the comment docs.

@codereport codereport marked this pull request as ready for review January 26, 2021 18:10
@codereport codereport requested a review from a team as a code owner January 26, 2021 18:10
@codereport codereport added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond and removed 2 - In Progress Currently a work in progress labels Jan 26, 2021
@revans2
Copy link
Contributor

revans2 commented Jan 26, 2021

This is great I was able to get a version of divide working for the Spark RAPIDS Accelerator.

@codereport
Copy link
Contributor Author

This is great I was able to get a version of divide working for the Spark RAPIDS Accelerator.

Awesome! 🔥

@revans2 revans2 mentioned this pull request Jan 26, 2021
Merged
harrism
harrism requested changes Jan 27, 2021
View reviewed changes
cpp/include/cudf/fixed_point/fixed_point.hpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Show resolved Hide resolved
@codereport codereport requested a review from harrism January 27, 2021 14:39
nvdbaranec
nvdbaranec requested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Outdated Show resolved Hide resolved
cpp/src/binaryop/binaryop.cpp Show resolved Hide resolved
@codereport codereport requested a review from nvdbaranec January 27, 2021 16:56
@codereport codereport requested a review from devavret January 28, 2021 19:27
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Jan 29, 2021
@codereport
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b097b5a into rapidsai:branch-0.18 Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@harrism harrism harrism approved these changes

@devavret devavret Awaiting requested review from devavret

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codereport @revans2 @harrism @devavret @jrhemstad @nvdbaranec