Add in support for Decimal divide #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
jlowe
reviewed
Jan 26, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
jlowe
previously approved these changes
Jan 27, 2021
|
The cudf dependency was merged in this morning. I will try to take this out of draft once CI finishes getting everything ready for the build |
|
build |
|
@revans2 with the recent cudf snapshot published, is this now ready to go? |
|
build |
|
@jlowe There were merge conflicts that I had to take care of. It should be good to go now. |
jlowe
approved these changes
Feb 4, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked waiting on rapidsai/cudf#7198 to be merged in.
This is similar to multiply where we cannot support the full range of scale/precision that spark can, not just because of 64-bit limitations.
This is a part of #1572
This also fixes two bugs that I found.
One were GpuCheckOverflow was not rounding when it should and the other was for DivModLike where the null output was getting the wrong type in some cases (especially with decimal values)