Interval index and interval_range #7182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenezw
added
2 - In Progress
marlenezw
added
improvement
shwina
reviewed
Jan 21, 2021
shwina
reviewed
Jan 25, 2021
Co-authored-by: Ashwin Srinath <[email protected]>
marlenezw
commented
Apr 1, 2021
kkraus14
reviewed
Apr 1, 2021
|
rerun tests |
kkraus14
reviewed
Apr 2, 2021
|
rerun tests |
kkraus14
reviewed
Apr 2, 2021
Co-authored-by: Keith Kraus <[email protected]>
kkraus14
reviewed
Apr 2, 2021
kkraus14
approved these changes
Apr 2, 2021
kkraus14
added
5 - Ready to Merge
|
Awesome work @marlenezw! Thanks @isVoid for helping to bring it over the finish line! |
|
@gpucibot merge |
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Apr 7, 2021
This PR is a follow up to PR rapidsai#6984. It adds the IntervalIndex and interval_range classes to CuDF. IntervalIndex is needed for the `cut` and `histogram` methods and closes issue rapidsai#5376. The main files to take note of in this PR are `index.py` and the two cudf `__init__.py` files. The rest of the file changes are related to PR6984 for creating the interval dtype. Authors: - Marlene (https://github.com/marlenezw) - Michael Wang (https://github.com/isVoid) Approvers: - Keith Kraus (https://github.com/kkraus14) URL: rapidsai#7182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to PR #6984. It adds the IntervalIndex and interval_range classes to CuDF. IntervalIndex is needed for the
cutandhistogrammethods and closes issue #5376.The main files to take note of in this PR are
index.pyand the two cudf__init__.pyfiles. The rest of the file changes are related to PR6984 for creating the interval dtype.