Adding Interval Dtype #6984
Merged
Adding Interval Dtype #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenezw
added
Python
|
Working on adding a few more tests and adjusting the dtype to change based on |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #6984 +/- ##
==============================================
Coverage ? 82.23%
==============================================
Files ? 101
Lines ? 17060
Branches ? 0
==============================================
Hits ? 14029
Misses ? 3031
Partials ? 0 Continue to review full report at Codecov.
|
marlenezw
added
3 - Ready for Review
shwina
reviewed
Dec 16, 2020
shwina
reviewed
Dec 16, 2020
shwina
reviewed
Dec 16, 2020
shwina
reviewed
Dec 16, 2020
shwina
reviewed
Dec 16, 2020
shwina
reviewed
Dec 16, 2020
Co-authored-by: Ashwin Srinath <[email protected]>
…to interval_dtype
marlenezw
added
the
improvement
kkraus14
reviewed
Feb 1, 2021
ajschmidt8
previously requested changes
Feb 16, 2021
There was a problem hiding this comment.
hi @marlenezw, please make sure to remove the CHANGELOG.md changes from this PR. changelog entries are now handled automatically and any manual edits risk breaking the automation. thanks!
kkraus14
reviewed
Feb 16, 2021
kkraus14
reviewed
Feb 16, 2021
kkraus14
reviewed
Feb 17, 2021
Co-authored-by: Keith Kraus <[email protected]>
kkraus14
approved these changes
Feb 18, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2021
This PR is a follow up to PR #6984. It adds the IntervalIndex and interval_range classes to CuDF. IntervalIndex is needed for the `cut` and `histogram` methods and closes issue #5376. The main files to take note of in this PR are `index.py` and the two cudf `__init__.py` files. The rest of the file changes are related to PR6984 for creating the interval dtype. Authors: - Marlene (https://github.com/marlenezw) - Michael Wang (https://github.com/isVoid) Approvers: - Keith Kraus (https://github.com/kkraus14) URL: #7182
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Apr 7, 2021
This PR is a follow up to PR rapidsai#6984. It adds the IntervalIndex and interval_range classes to CuDF. IntervalIndex is needed for the `cut` and `histogram` methods and closes issue rapidsai#5376. The main files to take note of in this PR are `index.py` and the two cudf `__init__.py` files. The rest of the file changes are related to PR6984 for creating the interval dtype. Authors: - Marlene (https://github.com/marlenezw) - Michael Wang (https://github.com/isVoid) Approvers: - Keith Kraus (https://github.com/kkraus14) URL: rapidsai#7182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add the Interval Dtype to CuDF. Interval is an ExtensionDtype for Interval data. This PR closes #5376.