Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add informative error message for sep in CSV writer #7095

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[REVIEW] Add informative error message for sep in CSV writer #7095

merged 1 commit into from
Jan 7, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #7091

This PR introduces validation and throwing of informative error messages for the sep parameter in csv writer.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Jan 7, 2021
@galipremsagar galipremsagar self-assigned this Jan 7, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner January 7, 2021 16:16
@galipremsagar galipremsagar requested a review from shwina January 7, 2021 16:16
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #7095 (e0b5daa) into branch-0.18 (f768da7) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7095      +/-   ##
===============================================
+ Coverage        82.10%   82.36%   +0.26%     
===============================================
  Files               97       97              
  Lines            16487    16859     +372     
===============================================
+ Hits             13536    13886     +350     
- Misses            2951     2973      +22
Impacted Files Coverage Δ
python/cudf/cudf/io/csv.py 93.87% <100.00%> (+0.54%) ⬆️
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 91.60% <0.00%> (+0.44%) ⬆️
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 58.53% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f768da7...e0b5daa. Read the comment docs.

@rapids-bot rapids-bot bot merged commit aa38f85 into rapidsai:branch-0.18 Jan 7, 2021
@galipremsagar galipremsagar mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina Awaiting requested review from shwina

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Explicit error message is missing for sep in CSV writer
3 participants
@galipremsagar @kkraus14 @vuule