Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add List types support in data generator #7064

Merged
merged 17 commits into from
Feb 1, 2021
Merged

[REVIEW] Add List types support in data generator #7064

merged 17 commits into from
Feb 1, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 4, 2021 •
edited
Loading

Resolves: #6263

This PR introduces changes which will enable generation of random list columns in datagenerator which will be used as part of fuzz tests.

cc: @vuule

@galipremsagar galipremsagar added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels Jan 4, 2021
@galipremsagar galipremsagar self-assigned this Jan 4, 2021
@codecov
Copy link

codecov bot commented Jan 4, 2021 •
edited
Loading

Codecov Report

Merging #7064 (1715ee7) into branch-0.18 (8860baf) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7064      +/-   ##
===============================================
+ Coverage        82.09%   82.16%   +0.06%     
===============================================
  Files               97       99       +2     
  Lines            16474    16856     +382     
===============================================
+ Hits             13524    13849     +325     
- Misses            2950     3007      +57
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/avro.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/csv.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/json.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/orc.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/parquet.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <ø> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b0900...1715ee7. Read the comment docs.

@galipremsagar galipremsagar changed the title [WIP] Add List types support in data generator [REVIEW] Add List types support in data generator Jan 4, 2021
@galipremsagar galipremsagar marked this pull request as ready for review January 4, 2021 23:21
@galipremsagar galipremsagar requested a review from a team as a code owner January 4, 2021 23:21
@galipremsagar galipremsagar added 4 - Needs cuIO Reviewer 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 4, 2021
@galipremsagar galipremsagar changed the title [REVIEW] Add List types support in data generator [WIP] Add List types support in data generator Jan 8, 2021
@galipremsagar galipremsagar marked this pull request as draft January 8, 2021 19:03
@galipremsagar galipremsagar marked this pull request as draft January 28, 2021 16:01
@galipremsagar galipremsagar added 0 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team 4 - Needs cuIO Reviewer labels Jan 28, 2021
@galipremsagar galipremsagar changed the title [REVIEW] Add List types support in data generator [WIP] Add List types support in data generator Jan 28, 2021
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress and removed 0 - Waiting on Author Waiting for author to respond to review labels Jan 29, 2021
@galipremsagar galipremsagar changed the title [WIP] Add List types support in data generator [REVIEW] Add List types support in data generator Jan 30, 2021
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels Jan 30, 2021
@galipremsagar galipremsagar marked this pull request as ready for review January 30, 2021 02:13
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 1, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 50be922 into rapidsai:branch-0.18 Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@vuule vuule vuule approved these changes

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Create list column support in random data-generator
3 participants
@galipremsagar @brandon-b-miller @vuule