-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comparisons between Series and cudf.NA #7072
Fix comparisons between Series and cudf.NA #7072
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7072 +/- ##
===============================================
+ Coverage 82.09% 82.12% +0.03%
===============================================
Files 97 97
Lines 16474 16498 +24
===============================================
+ Hits 13524 13549 +25
+ Misses 2950 2949 -1
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some unit-tests so that we can be sure we don't regress on this fix in the future while changing this part of code?
@galipremsagar yes we should add tests. When I sat down to write them though, the issue of #7066 came up. This PR causes the code to "work", but we get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, probably we can just have an eq
test case and xfail rest of the comparisons(lt
, gt
, ...) mentioning the #7066 in xfail reason.
Fixes #7043, gives less than ideal results due to #7066.