-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Match pandas behavior for comparisons involving true nulls #7066
Comments
I think this is the crux of it. Pandas until recently didn't have true nulls and everything was hacky using floats/NaN. Not only does the proposed null logic make more sense, it's also higher performance because it doesn't require additional kernels/allocations to replace nulls w/ |
Fixes #7043, gives less than ideal results due to #7066. Authors: - brandon-b-miller <[email protected]> Approvers: - GALI PREM SAGAR (@galipremsagar) URL: #7072
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d. |
This is getting fixed this release (0.19) |
Is your feature request related to a problem? Please describe.
Nulls should propagate through comparisons the same way they do in Pandas. Any kind of comparison operation where
<NA>
is one of the operands should yield<NA>
. This is not currently so in cuDF:What we should have is:
Describe the solution you'd like
For all comparison operations, the mask of the resulting series should be the result of an elementwise logical
or
between the masks. I believe this is true in libcudf, and suspect we originally went a different way to match pandasnan
logic instead of true null. The same thing should work withcudf.NA
.Describe alternatives you've considered
Additional context
xref : issue #7043
The text was updated successfully, but these errors were encountered: