Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in numerical.py #6957

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

rgsl888prabhu
Copy link
Contributor

closes #6778

Fixes typo missed in PR #6887, the else condition where this is situated would be the last resort for any unaccounted scalar type values.

@rgsl888prabhu rgsl888prabhu added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Dec 9, 2020
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner December 9, 2020 20:57
@rgsl888prabhu rgsl888prabhu self-assigned this Dec 9, 2020
@rgsl888prabhu
Copy link
Contributor Author

rerun tests

1 similar comment
@rgsl888prabhu
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #6957 (b34d514) into branch-0.18 (5336301) will increase coverage by 0.06%.
The diff coverage is 95.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6957      +/-   ##
===============================================
+ Coverage        81.96%   82.03%   +0.06%     
===============================================
  Files               96       96              
  Lines            16177    16260      +83     
===============================================
+ Hits             13260    13339      +79     
- Misses            2917     2921       +4     
Impacted Files Coverage Δ
python/cudf/cudf/io/avro.py 78.57% <66.66%> (-3.25%) ⬇️
python/cudf/cudf/io/csv.py 93.75% <66.66%> (-2.00%) ⬇️
python/cudf/cudf/io/json.py 96.55% <66.66%> (-3.45%) ⬇️
python/cudf/cudf/io/orc.py 88.40% <66.66%> (-0.99%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <80.00%> (-1.18%) ⬇️
python/cudf/cudf/core/index.py 93.25% <93.75%> (+<0.01%) ⬆️
python/cudf/cudf/utils/utils.py 85.35% <93.75%> (+0.67%) ⬆️
python/cudf/cudf/core/dataframe.py 91.08% <97.29%> (-0.07%) ⬇️
python/cudf/cudf/core/column/categorical.py 93.33% <100.00%> (-0.04%) ⬇️
python/cudf/cudf/core/column/column.py 87.92% <100.00%> (+0.21%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a301e65...b34d514. Read the comment docs.

@rapids-bot rapids-bot bot merged commit ea9c689 into rapidsai:branch-0.18 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Typo in cudf/core/column/numerical.py: "Buffer has no attribute from_array_lik"
2 participants