Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typo in cudf/core/column/numerical.py: "Buffer has no attribute from_array_lik" #6778

Closed
cjnolet opened this issue Nov 16, 2020 · 2 comments · Fixed by #6887 or #6957
Closed
Assignees
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@cjnolet
Copy link
Member

cjnolet commented Nov 16, 2020

it looks like this is a typo because we receiving this error in our rapids-single-cell-examples notebooks:

image

It looks like this went out with the 0.16 release and is still present in the 0.17 branch. I only see the mispelling in that one file and I don't see see any other spellings that are missing the 'e'. Here's a grep of the cudf repo:

python/cudf/cudf/utils/cudautils.py:    output_dary = cuda.device_array_like(data)
python/cudf/cudf/core/column/numerical.py:                    data=Buffer.from_array_lik(ary),
python/cudf/cudf/core/buffer.py:        data : Buffer, array_like, int
python/cudf/cudf/core/buffer.py:            self._init_from_array_like(data, owner)
python/cudf/cudf/core/buffer.py:            self._init_from_array_like(np.asarray(data), owner)
python/cudf/cudf/core/buffer.py:            self._init_from_array_like(np.asarray(data), owner)
python/cudf/cudf/core/buffer.py:    def _init_from_array_like(self, data, owner):
python/cudf/cudf/core/buffer.py:            self._init_from_array_like(dbuf, owner)
python/cudf/cudf/core/frame.py:        lower : scalar or array_like, default None
python/cudf/cudf/core/frame.py:        upper : scalar or array_like, default None
docs/cudf/source/guide-to-udfs.ipynb:    "output_dary = rmm.device_array_like(a_dary)\n",
@cjnolet cjnolet added Needs Triage Need team to review and classify bug Something isn't working labels Nov 16, 2020
@kkraus14 kkraus14 added Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Nov 17, 2020
@rapids-bot rapids-bot bot closed this as completed in #6887 Dec 3, 2020
rapids-bot bot pushed a commit that referenced this issue Dec 3, 2020
Fixes typo and 0-d numpy array handling. When numpy scalar is used on lhs while executing binary operation, `__eq__` from numpy returns a 0-d array rather than scalar.

closes #6778

Authors:
  - Ramakrishna Prabhu <[email protected]>
  - Ram (Ramakrishna Prabhu) <[email protected]>

Approvers:
  - Keith Kraus

URL: #6887
@cjnolet
Copy link
Member Author

cjnolet commented Dec 9, 2020

I think this issue was referenced in a #6887 by mistake because I don't see any changes related to this and it looks like it hasn't been fixed. Can we open this issue back up?

@kkraus14
Copy link
Collaborator

kkraus14 commented Dec 9, 2020

@cjnolet #6887 was specifically fixing this issue. It turned out to be an 0d-array that caused going down the codepath with this typo, but was more generally unhandled.

EDIT: there's still the typo but I'm not sure it's even possible to get to that else branch anymore.

rapids-bot bot pushed a commit that referenced this issue Dec 11, 2020
closes #6778 

Fixes typo missed in PR #6887, the else condition where this is situated would be the last resort for any unaccounted scalar type values.

Authors:
  - Ramakrishna Prabhu <[email protected]>

Approvers:
  - Keith Kraus

URL: #6957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
3 participants