Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Enable groupby list aggregation for strings #6914

Merged
merged 13 commits into from
Dec 4, 2020
Merged

[REVIEW] Enable groupby list aggregation for strings #6914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
48a94d9
Add DecimalDtype.itemsize
shwina Nov 9, 2020
3264366
Add DecimalColumn
shwina Nov 9, 2020
71c835b
Merge branch 'branch-0.17' of https://github.com/rapidsai/cudf into b…
shwina Nov 19, 2020
d74e3d3
Merge branch 'branch-0.17' of https://github.com/rapidsai/cudf into b…
shwina Nov 23, 2020
3c7ad29
Merge branch 'branch-0.17' of https://github.com/rapidsai/cudf into b…
shwina Nov 30, 2020
358d582
Merge branch 'branch-0.17' of https://github.com/rapidsai/cudf into b…
shwina Dec 2, 2020
9c2741e
Enable groupby list for strings
shwina Dec 4, 2020
a2b25a0
Changelog
shwina Dec 4, 2020
13c86bc
Merge branch 'branch-0.17' into enable-groupby-list-strings
shwina Dec 4, 2020
d1ae993
Revert "Add DecimalDtype.itemsize"
shwina Dec 4, 2020
e19c42f
Revert "Add DecimalColumn"
shwina Dec 4, 2020
10dbd2e
Merge branch 'enable-groupby-list-strings' of github.com:shwina/cudf …
shwina Dec 4, 2020
57cca09
More tests
shwina Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@
- PR #6837 Avoid gather when copying strings view from start of strings column
- PR #6859 Move align_ptr_for_type() from cuda.cuh to alignment.hpp
- PR #6807 Refactor `std::array` usage in row group index writing in ORC
- PR #6914 Enable groupby `list` aggregation for strings
- PR #6908 Parquet option for strictly decimal reading

## Bug Fixes
Expand Down
1 change: 1 addition & 0 deletions python/cudf/cudf/_lib/groupby.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ _STRING_AGGS = {
"min",
"nunique",
"nth",
"collect"
}

_LIST_AGGS = {
Expand Down
20 changes: 20 additions & 0 deletions python/cudf/cudf/tests/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,6 +1268,26 @@ def test_groupby_list_single_element(list_agg):
)


@pytest.mark.parametrize(
"agg", [list, [list, "count"], {"b": list, "c": "sum"}]
)
def test_groupby_list_strings(agg):
pdf = pd.DataFrame(
{
"a": [1, 1, 1, 2, 2],
"b": ["b", "a", None, "e", "d"],
"c": [1, 2, 3, 4, 5],
}
)
gdf = cudf.from_pandas(pdf)

assert_eq(
pdf.groupby("a").agg(agg),
gdf.groupby("a").agg(agg),
check_dtype=False,
)


def test_groupby_list_columns_excluded():
pdf = pd.DataFrame(
{
Expand Down