Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Enable groupby list aggregation for strings #6914

Merged
merged 13 commits into from
Dec 4, 2020

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Dec 4, 2020

No description provided.

@shwina shwina requested a review from a team as a code owner December 4, 2020 18:50
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@shwina shwina added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Dec 4, 2020
@shwina shwina added the improvement Improvement / enhancement to an existing function label Dec 4, 2020
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge bug Something isn't working Python Affects Python cuDF API. and removed 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function labels Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #6914 (a2b25a0) into branch-0.17 (cd7a0ad) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #6914      +/-   ##
===============================================
- Coverage        81.96%   81.89%   -0.07%     
===============================================
  Files               96       97       +1     
  Lines            16231    16169      -62     
===============================================
- Hits             13303    13242      -61     
+ Misses            2928     2927       -1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/decimal.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 89.93% <66.66%> (-0.45%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-4.26%) ⬇️
python/cudf/cudf/utils/utils.py 84.25% <0.00%> (-1.11%) ⬇️
python/cudf/cudf/io/parquet.py 91.66% <0.00%> (-0.46%) ⬇️
python/cudf/cudf/utils/dtypes.py 88.71% <0.00%> (-0.39%) ⬇️
python/cudf/cudf/core/dataframe.py 90.99% <0.00%> (-0.16%) ⬇️
python/cudf/cudf/core/frame.py 89.93% <0.00%> (-0.13%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.44% <0.00%> (-0.12%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7a0ad...57cca09. Read the comment docs.

@rapids-bot rapids-bot bot merged commit bd321d1 into rapidsai:branch-0.17 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants