Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] FIX Add codecov upload block to gpu script #6860

Merged
merged 6 commits into from
Feb 4, 2021

Conversation

dillon-cullinan
Copy link
Contributor

This moves a block from the Jenkins build into the build script. Simplifies the Jenkins builds slightly and fixes a very rare case where tests may error and not be properly caught due to EXITCODE intricacies.

@dillon-cullinan dillon-cullinan requested a review from a team as a code owner November 30, 2020 21:22
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #6860 (b75f6cd) into branch-0.19 (bd537b6) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #6860      +/-   ##
===============================================
+ Coverage        81.92%   82.18%   +0.26%     
===============================================
  Files               96      100       +4     
  Lines            16167    16949     +782     
===============================================
+ Hits             13245    13930     +685     
- Misses            2922     3019      +97     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/methods.py 87.23% <0.00%> (-9.20%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-4.26%) ⬇️
python/cudf/cudf/io/csv.py 91.66% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/io/json.py 96.55% <0.00%> (-3.45%) ⬇️
python/cudf/cudf/io/avro.py 78.57% <0.00%> (-3.25%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 92.15% <0.00%> (-2.90%) ⬇️
python/cudf/cudf/io/orc.py 86.89% <0.00%> (-2.50%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.85% <0.00%> (-1.45%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (-1.18%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd537b6...b75f6cd. Read the comment docs.

@dillon-cullinan dillon-cullinan added bug Something isn't working non-breaking Non-breaking change labels Dec 1, 2020
@kkraus14 kkraus14 added the gpuCI label Feb 2, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Feb 2, 2021

@dillon-cullinan what's the plan with this PR?

@kkraus14 kkraus14 changed the base branch from branch-0.17 to branch-0.19 February 2, 2021 21:28
@dillon-cullinan
Copy link
Contributor Author

@kkraus14 should be good to merge after CI runs.

@kkraus14
Copy link
Collaborator

kkraus14 commented Feb 4, 2021

@gpucibot merge

@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 4, 2021
@rapids-bot rapids-bot bot merged commit a1133e1 into rapidsai:branch-0.19 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants