Skip to content

Commit

Permalink
FIX Add codecov upload block to gpu script (#6860)
Browse files Browse the repository at this point in the history
This moves a block from the Jenkins build into the build script. Simplifies the Jenkins builds slightly and fixes a very rare case where tests may error and not be properly caught due to EXITCODE intricacies.

Authors:
  - Dillon Cullinan (@dillon-cullinan)

Approvers:
  - Ray Douglass (@raydouglass)
  - AJ Schmidt (@ajschmidt8)

URL: #6860
  • Loading branch information
dillon-cullinan authored Feb 4, 2021
1 parent 7fd069e commit a1133e1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ Please see https://github.com/rapidsai/cudf/releases/tag/branch-0.18-latest for
- PR #6854 Fix the parameter order of writeParquetBufferBegin
- PR #6855 Fix `.str.replace_with_backrefs` docs examples
- PR #6853 Fix contiguous split of null string columns
- PR #6860 Move codecov upload to build script
- PR #6861 Fix compile error in type_dispatch_benchmark.cu
- PR #6864 Handle contiguous_split corner case for nested string columns with no children
- PR #6869 Avoid dependency resolution failure in latest version of pip by explicitly specifying versions for dask and distributed
Expand Down
6 changes: 5 additions & 1 deletion ci/gpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,8 @@ gpuci_logger "Test notebooks"
${WORKSPACE}/ci/gpu/test-notebooks.sh 2>&1 | tee nbtest.log
python ${WORKSPACE}/ci/utils/nbtestlog2junitxml.py nbtest.log

return ${EXITCODE}
if [ -n "${CODECOV_TOKEN}" ]; then
codecov -t $CODECOV_TOKEN
fi

return ${EXITCODE}

0 comments on commit a1133e1

Please sign in to comment.