-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Enable workaround to write categorical columns in csv #6829
[REVIEW] Enable workaround to write categorical columns in csv #6829
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6829 +/- ##
===============================================
- Coverage 82.31% 81.94% -0.37%
===============================================
Files 93 96 +3
Lines 15358 16142 +784
===============================================
+ Hits 12642 13228 +586
- Misses 2716 2914 +198
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @galipremsagar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question regarding test case
This PR introduces stopgap solution to write categorical data to csv. In addition, there are also changes to raise error messages to some of the existing issues in CSV reader and writer.