Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Enable workaround to write categorical columns in csv #6829

Merged
merged 5 commits into from
Nov 23, 2020

Conversation

galipremsagar
Copy link
Contributor

This PR introduces stopgap solution to write categorical data to csv. In addition, there are also changes to raise error messages to some of the existing issues in CSV reader and writer.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Nov 23, 2020
@galipremsagar galipremsagar requested a review from a team as a code owner November 23, 2020 03:04
@galipremsagar galipremsagar self-assigned this Nov 23, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #6829 (c097977) into branch-0.17 (e01ab96) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #6829      +/-   ##
===============================================
- Coverage        82.31%   81.94%   -0.37%     
===============================================
  Files               93       96       +3     
  Lines            15358    16142     +784     
===============================================
+ Hits             12642    13228     +586     
- Misses            2716     2914     +198     
Impacted Files Coverage Δ
python/cudf/cudf/benchmarks/bench_cudf_io.py 30.61% <0.00%> (-12.25%) ⬇️
python/cudf/cudf/io/orc.py 89.39% <0.00%> (-8.23%) ⬇️
python/cudf/cudf/utils/ioutils.py 79.88% <0.00%> (-6.23%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.68% <0.00%> (-0.67%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.50% <0.00%> (-0.49%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 91.07% <0.00%> (-0.29%) ⬇️
python/cudf/cudf/core/column/string.py 86.79% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/io/parquet.py 91.66% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/gpuarrow.py 79.76% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbeac89...c097977. Read the comment docs.

Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Nov 23, 2020
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question regarding test case

python/cudf/cudf/io/csv.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants