Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce HtoD copies in cudf::concatenate #6605 #6605

Merged
merged 19 commits into from
Nov 28, 2020
Merged

reduce HtoD copies in cudf::concatenate #6605 #6605

merged 19 commits into from
Nov 28, 2020

Conversation

karthikeyann
Copy link
Contributor

closes #6465
reduces multiple HtoD copies in cudf::concatenate by adding create_contiguous_device_views for list of column_views

@karthikeyann karthikeyann added the Performance Performance related issue label Oct 27, 2020
@karthikeyann karthikeyann self-assigned this Oct 27, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@karthikeyann karthikeyann mentioned this pull request Oct 28, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #6605 (0bf94bc) into branch-0.17 (c34d9bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #6605   +/-   ##
============================================
  Coverage        81.94%   81.94%           
============================================
  Files               96       96           
  Lines            16164    16164           
============================================
  Hits             13246    13246           
  Misses            2918     2918

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34d9bf...0bf94bc. Read the comment docs.

@karthikeyann karthikeyann mentioned this pull request Nov 4, 2020
Closed
@karthikeyann karthikeyann marked this pull request as ready for review November 19, 2020 14:19
@karthikeyann karthikeyann requested a review from a team as a code owner November 19, 2020 14:19
@karthikeyann karthikeyann changed the title [WIP] reduce HtoD copies in cudf::concatenate [REVIEW] reduce HtoD copies in cudf::concatenate Nov 19, 2020
harrism
harrism requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few suggestions.

cpp/include/cudf/column/column_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
jrhemstad
jrhemstad requested changes Nov 20, 2020
View reviewed changes
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/column/column_device_view.cuh Outdated Show resolved Hide resolved
cpp/include/cudf/table/table_device_view.cuh Outdated Show resolved Hide resolved
harrism
harrism approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Jake's suggestions, looks good. Just one tiny cleanup of a for->for_each.

cpp/include/cudf/column/column_device_view.cuh Outdated Show resolved Hide resolved
@harrism harrism added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. labels Nov 24, 2020
@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 28, 2020
@karthikeyann karthikeyann changed the title [REVIEW] reduce HtoD copies in cudf::concatenate reduce HtoD copies in cudf::concatenate #6605 Nov 28, 2020
@karthikeyann karthikeyann merged commit 0b58244 into rapidsai:branch-0.17 Nov 28, 2020
@karthikeyann karthikeyann deleted the enh-string_concatenate_HtoD_copies branch November 28, 2020 02:16
@davidwendt davidwendt mentioned this pull request Nov 30, 2020
Closed
@jrhemstad jrhemstad mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@harrism harrism harrism approved these changes

@cwharris cwharris Awaiting requested review from cwharris

@davidwendt davidwendt Awaiting requested review from davidwendt

Assignees

@karthikeyann karthikeyann

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] concatenate on many string columns causes storm of synchronized HtoD copies
5 participants
@karthikeyann @GPUtester @harrism @jrhemstad @davidwendt