Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cudf::detail::align_ptr_for_type from cuda.cuh to .hpp header #6857

Closed
davidwendt opened this issue Nov 30, 2020 · 0 comments · Fixed by #6859
Closed

Move cudf::detail::align_ptr_for_type from cuda.cuh to .hpp header #6857

davidwendt opened this issue Nov 30, 2020 · 0 comments · Fixed by #6859
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@davidwendt
Copy link
Contributor

The changes to #6605 included a new function cudf::detail::align_ptr_for_type which is defined in cudf/detail/utilities/cuda.cuh here:

cudf/cpp/include/cudf/detail/utilities/cuda.cuh

Line 183 in f3c9322

T* align_ptr_for_type(void* destination)

This function contains only C++ STL code and no CUDA code. Also, including it in the column_device_view.cuh now requires a new dependency on cub/cub.cuh (per the cuda.cuh) as found when building blazingSQL.

Recommend moving this definition to an existing or new .hpp file.
@davidwendt davidwendt added bug Something isn't working Needs Triage Need team to review and classify libcudf Affects libcudf (C++/CUDA) code. labels Nov 30, 2020
@davidwendt davidwendt mentioned this issue Nov 30, 2020
Merged
@rapids-bot rapids-bot bot closed this as completed in #6859 Dec 1, 2020
rapids-bot bot pushed a commit that referenced this issue Dec 1, 2020
@davidwendt
Move align_ptr_for_type() from cuda.cuh to alignment.hpp(#6859)
cdc53b7 
Closes #6857 

This function contains only C++ STL code and no CUDA code. Also, including it in the `column_device_view.cuh` required a new dependency on `cub/cub.cuh` (per the `cuda.cuh`) as found when building blazingSQL.

Authors:
  - davidwendt <[email protected]>

Approvers:
  - Ram (Ramakrishna Prabhu)
  - Mark Harris
  - Ray Douglass

URL: #6859
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move align_ptr_for_type() from cuda.cuh to alignment.hpp davidwendt/cudf
2 participants
@bdice @davidwendt