Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Reduce number of concatenate benchmark test cases #5743

Merged

Conversation

trevorsm7
Copy link
Contributor

The concatenate benchmark is taking an excessive amount of CI time because it sweeps a large range of parameters. Increasing the range multiplier from 4 to 8 will greatly reduce the number of test cases, which should alleviate the issue.

@trevorsm7 trevorsm7 added 3 - Ready for Review Ready for review by team gpuCI labels Jul 22, 2020
@trevorsm7 trevorsm7 requested a review from a team as a code owner July 22, 2020 18:43
@trevorsm7 trevorsm7 self-assigned this Jul 22, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

1 similar comment
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #5743 into branch-0.15 will decrease coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5743      +/-   ##
===============================================
- Coverage        88.65%   86.38%   -2.27%     
===============================================
  Files               57       76      +19     
  Lines            10945    13036    +2091     
===============================================
+ Hits              9703    11261    +1558     
- Misses            1242     1775     +533     
Impacted Files Coverage Δ
python/cudf/cudf/core/dtypes.py 87.71% <0.00%> (-9.21%) ⬇️
python/cudf/cudf/core/abc.py 91.30% <0.00%> (-3.15%) ⬇️
python/cudf/cudf/utils/ioutils.py 85.85% <0.00%> (-1.49%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 93.07% <0.00%> (-1.05%) ⬇️
python/cudf/cudf/core/frame.py 90.19% <0.00%> (-0.98%) ⬇️
python/cudf/cudf/core/indexing.py 95.27% <0.00%> (-0.63%) ⬇️
python/cudf/cudf/core/multiindex.py 80.34% <0.00%> (-0.29%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.33% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/io/avro.py 81.81% <0.00%> (ø)
python/cudf/cudf/core/ops.py 77.58% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f41adf...4404e42. Read the comment docs.

@harrism harrism merged commit fb797a3 into rapidsai:branch-0.15 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants