Skip to content

Commit

Permalink
Merge pull request #5743 from trevorsm7/fea-reduce-concatenate-benchm…
Browse files Browse the repository at this point in the history
…ark-cases

[REVIEW] Reduce number of concatenate benchmark test cases
  • Loading branch information
harrism authored Jul 23, 2020
2 parents 1f41adf + 4404e42 commit fb797a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
- PR #5720 Replace owning raw pointers with std::unique_ptr
- PR #5702 Add inherited methods to python docs and other docs fixes
- PR #5733 Add support for `size` property in `DataFrame`/ `Series` / `Index`/ `MultiIndex`
- PR #5743 Reduce number of test cases in concatenate benchmark

## Bug Fixes

Expand Down
6 changes: 3 additions & 3 deletions cpp/benchmarks/column/concatenate_benchmark.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ static void BM_concatenate(benchmark::State& state)
BENCHMARK_TEMPLATE_DEFINE_F(Concatenate, name, type, nullable) \
(::benchmark::State & state) { BM_concatenate<type, nullable>(state); } \
BENCHMARK_REGISTER_F(Concatenate, name) \
->RangeMultiplier(4) \
->RangeMultiplier(8) \
->Ranges({{1 << 6, 1 << 18}, {2, 1024}}) \
->Unit(benchmark::kMillisecond) \
->UseManualTime();
Expand Down Expand Up @@ -135,7 +135,7 @@ static void BM_concatenate_tables(benchmark::State& state)
BENCHMARK_TEMPLATE_DEFINE_F(Concatenate, name, type, nullable) \
(::benchmark::State & state) { BM_concatenate_tables<type, nullable>(state); } \
BENCHMARK_REGISTER_F(Concatenate, name) \
->RangeMultiplier(4) \
->RangeMultiplier(8) \
->Ranges({{1 << 8, 1 << 12}, {2, 32}, {2, 128}}) \
->Unit(benchmark::kMillisecond) \
->UseManualTime();
Expand Down Expand Up @@ -196,7 +196,7 @@ static void BM_concatenate_strings(benchmark::State& state)
BENCHMARK_TEMPLATE_DEFINE_F(ConcatenateStrings, name, nullable) \
(::benchmark::State & state) { BM_concatenate_strings<nullable>(state); } \
BENCHMARK_REGISTER_F(ConcatenateStrings, name) \
->RangeMultiplier(4) \
->RangeMultiplier(8) \
->Ranges({{1 << 8, 1 << 14}, {8, 128}, {2, 256}}) \
->Unit(benchmark::kMillisecond) \
->UseManualTime();
Expand Down

0 comments on commit fb797a3

Please sign in to comment.