Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix hash() and construct_join_output_df() to use user-provided memory resource correctly #5064

Merged
merged 4 commits into from
May 5, 2020
Merged

[REVIEW] Fix hash() and construct_join_output_df() to use user-provided memory resource correctly #5064

merged 4 commits into from
May 5, 2020

Conversation

magnatelee
Copy link
Contributor

@magnatelee magnatelee commented Apr 30, 2020 •
edited by trevorsm7
Loading

Closes #5065

This change fixes hash() and construct_join_output_df() so that they pass down the user-provided memory resource correctly.

@magnatelee magnatelee requested a review from a team as a code owner April 30, 2020 21:17
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

rgsl888prabhu
rgsl888prabhu approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog

rgsl888prabhu
rgsl888prabhu reviewed Apr 30, 2020
View reviewed changes
cpp/src/join/join.cu Outdated Show resolved Hide resolved
trevorsm7
trevorsm7 suggested changes May 1, 2020
View reviewed changes
Copy link
Contributor

@trevorsm7 trevorsm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work finding these. I think the common_from_right and common_from_left shouldn't be using mr though.

cpp/src/join/join.cu Outdated Show resolved Hide resolved
cpp/src/hash/hashing.cu Show resolved Hide resolved
@trevorsm7 trevorsm7 added 3 - Ready for Review Ready for review by team code quality libcudf Affects libcudf (C++/CUDA) code. labels May 1, 2020
@magnatelee magnatelee removed their assignment May 2, 2020
trevorsm7
trevorsm7 suggested changes May 2, 2020
View reviewed changes
Copy link
Contributor

@trevorsm7 trevorsm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add stream to the concatenate call as well

cpp/src/join/join.cu Show resolved Hide resolved
@trevorsm7 trevorsm7 mentioned this pull request May 2, 2020
Closed
@jrhemstad
Copy link
Contributor

add to whitelist

@jrhemstad
Copy link
Contributor

okay to test

@kkraus14
Copy link
Collaborator

kkraus14 commented May 4, 2020

add to whitelist

@codecov
Copy link

codecov bot commented May 4, 2020 •
edited
Loading

Codecov Report

Merging #5064 into branch-0.14 will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.14    #5064      +/-   ##
===============================================
- Coverage        88.50%   88.44%   -0.06%     
===============================================
  Files               54       54              
  Lines            10270    10267       -3     
===============================================
- Hits              9089     9081       -8     
- Misses            1181     1186       +5
Impacted Files Coverage Δ
python/cudf/cudf/core/buffer.py 82.92% <0.00%> (-3.66%) ⬇️
python/cudf/cudf/core/column/column.py 86.19% <0.00%> (-0.35%) ⬇️
python/cudf/cudf/core/column/string.py 84.97% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 93.89% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6ce93...95312da. Read the comment docs.

@trevorsm7 trevorsm7 merged commit 1336a3a into rapidsai:branch-0.14 May 5, 2020
@trevorsm7 trevorsm7 mentioned this pull request May 6, 2020
Closed
@magnatelee magnatelee deleted the user_resource_fix branch May 8, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@trevorsm7 trevorsm7 trevorsm7 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] hash() and construct_join_output_df ignoring user-provided memory resource
6 participants
@magnatelee @GPUtester @jrhemstad @kkraus14 @trevorsm7 @rgsl888prabhu