Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] hash() and construct_join_output_df ignoring user-provided memory resource #5065

Closed
magnatelee opened this issue Apr 30, 2020 · 1 comment · Fixed by #5064
Closed

[BUG] hash() and construct_join_output_df ignoring user-provided memory resource #5065

magnatelee opened this issue Apr 30, 2020 · 1 comment · Fixed by #5064
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@magnatelee
Copy link
Contributor

Describe the bug
hash() and construct_join_output_df are currently ignoring the user-provided memory resource that was passed in. Here are the calls that are supposed to take the user-provided resource:

https://github.com/rapidsai/cudf/blob/branch-0.14/cpp/src/hash/hashing.cu#L646
https://github.com/rapidsai/cudf/blob/branch-0.14/cpp/src/join/join.cu#L314-L321
https://github.com/rapidsai/cudf/blob/branch-0.14/cpp/src/join/join.cu#L328-L331
https://github.com/rapidsai/cudf/blob/branch-0.14/cpp/src/join/join.cu#L337-L340
https://github.com/rapidsai/cudf/blob/branch-0.14/cpp/src/join/join.cu#L343-L346
@magnatelee magnatelee added Needs Triage Need team to review and classify bug Something isn't working labels Apr 30, 2020
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels May 5, 2020
@trevorsm7
Copy link
Contributor

This should have been closed by #5064

@magnatelee magnatelee mentioned this issue May 6, 2020
Merged
@magnatelee magnatelee mentioned this issue May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
3 participants
@magnatelee @kkraus14 @trevorsm7