[REVIEW] Add benchmark build option to root build.sh #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kkraus14
reviewed
Sep 12, 2019
| @@ -131,6 +137,7 @@ if (( ${NUMARGS} == 0 )) || hasArg libcudf; then | |||
| cd ${LIBCUDF_BUILD_DIR} | |||
| cmake -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \ | |||
| -DCMAKE_CXX11_ABI=ON \ | |||
| -DBUILD_BENCHMARKS=${BENCHMARKS} \ | |||
There was a problem hiding this comment.
Do you want to do with this approach or do you want a make bench cmake command(s) similar to tests?
There was a problem hiding this comment.
Ultimately something you described is ideal. I'm trying to get this integrated in a nightly Jenkins build today, so this is more of a bandaid patch to keep it easy to work with for now.
kkraus14
approved these changes
Sep 12, 2019
Codecov Report
@@ Coverage Diff @@
## branch-0.10 #2786 +/- ##
===============================================
- Coverage 86.44% 86.43% -0.01%
===============================================
Files 48 48
Lines 8857 8855 -2
===============================================
- Hits 7656 7654 -2
Misses 1201 1201
Continue to review full report at Codecov.
|
rlratzel
reviewed
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #2784