Skip to content

Commit

Permalink
Merge pull request #2786 from dillon-cullinan/fea-build-bench
Browse files Browse the repository at this point in the history
[REVIEW] Add benchmark build option to root build.sh
  • Loading branch information
dillon-cullinan authored Sep 12, 2019
2 parents 2a92b88 + be0e09d commit f94b0f7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- PR #2724 Add libcudf support for __contains__
- PR #2743 Add Java bindings for NVStrings timestamp2long as part of String ColumnVector casting
- PR #2785 Add nvstrings Python docs
- PR #2786 Add benchmarks option to root build.sh

## Improvements

Expand Down
10 changes: 8 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,16 @@ ARGS=$*
# script, and that this script resides in the repo dir!
REPODIR=$(cd $(dirname $0); pwd)

VALIDARGS="clean libnvstrings nvstrings libcudf cudf dask_cudf -v -g -n -h"
HELP="$0 [clean] [libcudf] [cudf] [dask_cudf] [-v] [-g] [-n] [-h]
VALIDARGS="clean libnvstrings nvstrings libcudf cudf dask_cudf benchmarks -v -g -n -h"
HELP="$0 [clean] [libcudf] [cudf] [dask_cudf] [benchmarks] [-v] [-g] [-n] [-h]
clean - remove all existing build artifacts and configuration (start
over)
libnvstrings - build the nvstrings C++ code only
nvstrings - build the nvstrings Python package
libcudf - build the cudf C++ code only
cudf - build the cudf Python package
dask_cudf - build the dask_cudf Python package
benchmarks - build benchmarks
-v - verbose build mode
-g - build for debug
-n - no install step
Expand All @@ -46,6 +47,7 @@ BUILD_DIRS="${LIBNVSTRINGS_BUILD_DIR} ${NVSTRINGS_BUILD_DIR} ${LIBCUDF_BUILD_DIR
VERBOSE=""
BUILD_TYPE=Release
INSTALL_TARGET=install
BENCHMARKS=OFF

# Set defaults for vars that may not have been defined externally
# FIXME: if INSTALL_PREFIX is not set, check PREFIX, then check
Expand Down Expand Up @@ -82,6 +84,9 @@ fi
if hasArg -n; then
INSTALL_TARGET=""
fi
if hasArg benchmarks; then
BENCHMARKS="ON"
fi

# If clean given, run it prior to any other steps
if hasArg clean; then
Expand Down Expand Up @@ -131,6 +136,7 @@ if (( ${NUMARGS} == 0 )) || hasArg libcudf; then
cd ${LIBCUDF_BUILD_DIR}
cmake -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
-DCMAKE_CXX11_ABI=ON \
-DBUILD_BENCHMARKS=${BENCHMARKS} \
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} ..
if [[ ${INSTALL_TARGET} != "" ]]; then
make -j${PARALLEL_LEVEL} install_cudf VERBOSE=${VERBOSE}
Expand Down

0 comments on commit f94b0f7

Please sign in to comment.