Remove unused functionality in cudf._lib.utils.pyx #17586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
If everything left is for pylibcudf interop, there may be a more descriptive name than “utils.” Feel free to punt on this.
There was a problem hiding this comment.
Thanks. I think, if anything, the remaining used functions will be moved to cudf/utils/ioutils.py so I'll punt on the intermediate rename
|
In Morpheus we use the following which are being removed that we will need an alternative for:
|
|
Will not merge until nv-morpheus/Morpheus#2082 is in |
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Dec 16, 2024
In anticipation of this downstream cuDF PR removing some functionality in `cudf._lib.utils` rapidsai/cudf#17586, this PR replaces that usage with equivalent usage from the stable `pylibcudf` ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Matthew Roeschke (https://github.com/mroeschke) - David Gardner (https://github.com/dagardner-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #2082
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
More can be removed once my other cudf._lib PRs are in
Checklist