Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctest fail running libcudf tests in a Debug build #17576

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Fix ctest fail running libcudf tests in a Debug build #17576

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd2a6f0
Fix ctest fail running libcudf tests in a Debug build
davidwendt Dec 11, 2024
272774e
added changes from PR 17573
davidwendt Dec 11, 2024
e637cbe
Merge branch 'branch-25.02' into ctest-debug-bug
davidwendt Dec 11, 2024
1ba98eb
Merge branch 'branch-25.02' into ctest-debug-bug
davidwendt Dec 11, 2024
8eb63e9
Merge branch 'branch-25.02' into ctest-debug-bug
davidwendt Dec 12, 2024
0d8fe20
use rmm::logger instead of cudf::cudf
davidwendt Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ if(CUDF_BUILD_STREAMS_TEST_UTIL)
${_tgt} PRIVATE "$<BUILD_INTERFACE:$<$<COMPILE_LANGUAGE:CXX>:${CUDF_CXX_FLAGS}>>"
)
target_include_directories(${_tgt} PRIVATE "$<BUILD_INTERFACE:${CUDF_SOURCE_DIR}/include>")
target_link_libraries(${_tgt} PUBLIC CUDA::cudart rmm::rmm)
target_link_libraries(${_tgt} PUBLIC CUDA::cudart rmm::rmm cudf::cudf)
davidwendt marked this conversation as resolved.
Show resolved Hide resolved
if(CUDF_BUILD_STACKTRACE_DEBUG)
target_link_libraries(${_tgt} PRIVATE cudf_backtrace)
endif()
Expand Down
Loading