Force Thrust to use 32-bit offset type. #17523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
approved these changes
Dec 5, 2024
bdice
added
bug
|
We can ignore the telemetry-summarize failure, it is not required for merge. |
|
Patching is a bit messy here but I'd be fine merging if necessary. The cleaner option would be |
|
@vyasr Thanks -- I was wondering if that would be your preference. I would like to merge this to unblock CI and will follow up with another PR to do what you're proposing. Can you approve? |
vyasr
approved these changes
Dec 5, 2024
|
/merge |
rapids-bot
bot
merged commit fbc3256
into
rapidsai:branch-25.02
108 of 109 checks passed
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
…fset types. (#17527) Follow-up for #17523 to use `target_compile_definitions` and drop the Thrust patch. Authors: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #17527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the patch we use for Thrust to always get a 32-bit offset type. The net effect of this patch is that we are behaving as if
THRUST_FORCE_32_BIT_OFFSET_TYPEis set. This replaces a previous patch which I mistakenly did not update between CCCL 2.6.x testing and 2.7.0-rc2 testing.In the future we hope to configure this with CMake and drop the patches, but that will require us to use features from NVIDIA/cccl#2844 (which is not available in 2.7.0-rc2).
Checklist