-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thrust_create_target
DISPATCH
option.
#2844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
requested review from
wmaxey,
ericniebler,
robertmaynard and
miscco
November 15, 2024 22:06
alliepiper
force-pushed
the
thrust_dispatch_type
branch
from
November 15, 2024 22:33
d826b67
to
0ea3700
Compare
🟨 CI finished in 1h 51m: Pass: 75%/4 | Total: 1h 47m | Avg: 26m 58s | Max: 41m 03s
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 4)
# | Runner |
---|---|
2 | linux-amd64-cpu16 |
2 | linux-amd64-gpu-v100-latest-1 |
These will end up specifying conflicting flags when `THRUST_DISPATCH_TYPE` is set to something other than `Dynamic`.
``` thrust_create_target(TargetName DISPATCH [Dynamic|Force32bit|Force64bit] ```
alliepiper
force-pushed
the
thrust_dispatch_type
branch
2 times, most recently
from
November 18, 2024 19:58
a30fc91
to
c80807e
Compare
alliepiper
force-pushed
the
thrust_dispatch_type
branch
from
November 18, 2024 20:35
c80807e
to
c7a87ae
Compare
This is far more likely to break than 64-bit dispatch, so having it run per-PR makes sense. 64-bit dispatch is only tested in the nightly CI.
alliepiper
force-pushed
the
thrust_dispatch_type
branch
from
November 18, 2024 20:44
c7a87ae
to
421404e
Compare
🟩 CI finished in 1h 06m: Pass: 100%/4 | Total: 42m 36s | Avg: 10m 39s | Max: 17m 29s
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 4)
# | Runner |
---|---|
2 | linux-amd64-cpu16 |
2 | linux-amd64-gpu-v100-latest-1 |
alliepiper
force-pushed
the
thrust_dispatch_type
branch
from
November 18, 2024 22:00
421404e
to
d86673b
Compare
🟨 CI finished in 1h 32m: Pass: 99%/402 | Total: 2d 10h | Avg: 8m 42s | Max: 46m 39s | Hits: 74%/21970
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 402)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
32 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 15h 36m: Pass: 100%/402 | Total: 2d 10h | Avg: 8m 42s | Max: 46m 39s | Hits: 74%/21970
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 402)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
32 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
bernhardmgruber
approved these changes
Nov 19, 2024
bdice
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Will this target 2.7 or 2.8? We can always backport a patch on the RAPIDS side if it solves the problem. I will try to test it with cuDF today.
I believe this will go into 2.8.0. |
🟩 CI finished in 3h 49m: Pass: 100%/402 | Total: 1d 19h | Avg: 6m 32s | Max: 53m 17s | Hits: 99%/21970
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 402)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
32 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
trxcllnt
pushed a commit
to trxcllnt/cccl
that referenced
this pull request
Nov 23, 2024
* Remove the THRUST_DISPATCH_TYPE header tests. These will end up specifying conflicting flags when `THRUST_DISPATCH_TYPE` is set to something other than `Dynamic`. * Add `DISPATCH` option to `thrust_create_target`. ``` thrust_create_target(TargetName DISPATCH [Dynamic|Force32bit|Force64bit] ``` * Skip 64-bit offset tests when forcing 32-bit dispatch. * Add 32/64-bit dispatch jobs to nightly CI. * Add 32-bit dispatch to pull_request workflow.
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Dec 5, 2024
This fixes the patch we use for Thrust to always get a 32-bit offset type. The net effect of this patch is that we are behaving as if `THRUST_FORCE_32_BIT_OFFSET_TYPE` is set. This replaces a previous patch which I mistakenly did not update between CCCL 2.6.x testing and 2.7.0-rc2 testing. In the future we hope to configure this with CMake and drop the patches, but that will require us to use features from NVIDIA/cccl#2844 (which is not available in 2.7.0-rc2). Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Vyas Ramasubramani (https://github.com/vyasr) URL: #17523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
DISPATCH
option tothrust_create_target
.Adds 32/64-bit dispatch jobs to nightly CI. Updated docs. Various drive-by fixes.
CI Jobs with 32-/64-bit forced dispatch: https://github.com/NVIDIA/cccl/actions/runs/11900778160/job/33162677687
Checklist