Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libcudf compile error when logging is disabled #17512

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix libcudf compile error when logging is disabled #17512

merged 1 commit into from
Dec 4, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Adds [[maybe_unused]] to the compression_type_name function to prevent the warning/error.
Error/warning introduced in #17431
Closes #17510

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Dec 4, 2024
@davidwendt davidwendt self-assigned this Dec 4, 2024
@davidwendt davidwendt requested a review from a team as a code owner December 4, 2024 16:56
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1b82963 into rapidsai:branch-25.02 Dec 4, 2024
109 checks passed
@davidwendt davidwendt deleted the maybe-unused-comp-type-name branch December 4, 2024 21:33
@jlowe jlowe mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@mythrocks mythrocks mythrocks approved these changes

@jlowe jlowe jlowe approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] nvcomp_adapter fails to compile if cudf logging is disabled
5 participants
@davidwendt @jlowe @mythrocks @mhaseeb123 @vuule