Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] nvcomp_adapter fails to compile if cudf logging is disabled #17510

Closed
jlowe opened this issue Dec 4, 2024 · 0 comments · Fixed by #17512
Closed

[BUG] nvcomp_adapter fails to compile if cudf logging is disabled #17510

jlowe opened this issue Dec 4, 2024 · 0 comments · Fixed by #17512
Assignees
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@jlowe
Copy link
Member

jlowe commented Dec 4, 2024

Describe the bug
After #17431 libcudf fails to compile when cudf logging is disabled with an error like the following:

[INFO]      [exec] /home/jlowe/src/spark-rapids-jni/thirdparty/cudf/cpp/src/io/comp/nvcomp_adapter.cpp:73:13: error: 'std::string cudf::io::nvcomp::{anonymous}::compression_type_name(cudf::io::nvcomp::compression_type)' defined but not used [-Werror=unused-function]
[INFO]      [exec]    73 | std::string compression_type_name(compression_type compression)
[INFO]      [exec]       |             ^~~~~~~~~~~~~~~~~~~~~
[INFO]      [exec] cc1plus: all warnings being treated as errors

Steps/Code to reproduce bug
Compile libcudf with -DLIBCUDF_LOGGING_LEVEL=OFF

Expected behavior
libcudf can compile with logging disabled

Environment overview (please complete the following information)

@jlowe jlowe added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS labels Dec 4, 2024
@davidwendt davidwendt self-assigned this Dec 4, 2024
@rapids-bot rapids-bot bot closed this as completed in 1b82963 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants