Support pivot with index or column arguments as lists #17373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
mroeschke
removed
the
improvement
bdice
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
This seems fine to me. Can you check if any of the other pivot related bugs are fixed by this?
https://github.com/rapidsai/cudf/issues?q=is%3Aissue%20state%3Aopen%20pivot
I feel like this PR might fix some of those. If you see any candidates, please add that this closes them and also add corresponding tests for those if needed.
Doubled checked those issues, and unfortunately this PR doesn't fix those issues. (Most are related to |
|
/merge |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #17360
Technically I suppose this was more of an enhancement since the documentation suggested only a single label was supported, but I'll mark as a bug since the error message was not informative.
Checklist