Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow melt(var_name=) to be a falsy label #16981

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Allow melt(var_name=) to be a falsy label #16981

merged 1 commit into from
Oct 4, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #16972

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Oct 2, 2024
@mroeschke mroeschke requested a review from a team as a code owner October 2, 2024 19:14
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d15bbfd into rapidsai:branch-24.12 Oct 4, 2024
97 checks passed
@mroeschke mroeschke deleted the bug/melt/var_name_falsy branch October 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] melt doesn't respect var_name=''
2 participants
@mroeschke @vyasr