Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] melt doesn't respect var_name='' #16972

Closed
MarcoGorelli opened this issue Oct 2, 2024 · 0 comments · Fixed by #16981
Closed

[BUG] melt doesn't respect var_name='' #16972

MarcoGorelli opened this issue Oct 2, 2024 · 0 comments · Fixed by #16981
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@MarcoGorelli
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Steps/Code to reproduce bug

import cudf

df = cudf.DataFrame({'A': ['a', 'b', 'c'],
                     'B': [1, 3, 5],
                     'C': [2, 4, 6]})
cudf.melt(df, id_vars=['A'], value_vars=['B'], var_name='')
   A variable  value
0  a        B      1
1  b        B      3
2  c        B      5

Expected behavior

   A     value
0  a  B      1
1  b  B      3
2  c  B      5

which is what pandas does

Environment overview (please complete the following information)

  • Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)]
  • Method of cuDF install: [conda, Docker, or from source]
    • If method of install is [Docker], provide docker pull & docker run commands used

cudf version 24.08.03

Environment details

***OS Information*** DISTRIB_ID=Ubuntu DISTRIB_RELEASE=20.04 DISTRIB_CODENAME=focal DISTRIB_DESCRIPTION="Ubuntu 20.04.6 LTS" NAME="Ubuntu" VERSION="20.04.6 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.6 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal Linux 4ee8e1893ef0 5.15.154+ #1 SMP Thu Jun 27 20:43:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
 ***GPU Information***
 Wed Oct  2 08:15:42 2024
 +-----------------------------------------------------------------------------------------+
 | NVIDIA-SMI 550.90.07              Driver Version: 550.90.07      CUDA Version: 12.4     |
 |-----------------------------------------+------------------------+----------------------+
 | GPU  Name                 Persistence-M | Bus-Id          Disp.A | Volatile Uncorr. ECC |
 | Fan  Temp   Perf          Pwr:Usage/Cap |           Memory-Usage | GPU-Util  Compute M. |
 |                                         |                        |               MIG M. |
 |=========================================+========================+======================|
 |   0  Tesla T4                       Off |   00000000:00:04.0 Off |                    0 |
 | N/A   55C    P0             29W /   70W |     107MiB /  15360MiB |      0%      Default |
 |                                         |                        |                  N/A |
 +-----------------------------------------+------------------------+----------------------+
 |   1  Tesla T4                       Off |   00000000:00:05.0 Off |                    0 |
 | N/A   36C    P8              9W /   70W |       3MiB /  15360MiB |      0%      Default |
 |                                         |                        |                  N/A |
 +-----------------------------------------+------------------------+----------------------+
 
 +-----------------------------------------------------------------------------------------+
 | Processes:                                                                              |
 |  GPU   GI   CI        PID   Type   Process name                              GPU Memory |
 |        ID   ID                                                               Usage      |
 |=========================================================================================|
 +-----------------------------------------------------------------------------------------+
 
 ***CPU***
 Architecture:                         x86_64
 CPU op-mode(s):                       32-bit, 64-bit
 Byte Order:                           Little Endian
 Address sizes:                        46 bits physical, 48 bits virtual
 CPU(s):                               4
 On-line CPU(s) list:                  0-3
 Thread(s) per core:                   2
 Core(s) per socket:                   2
 Socket(s):                            1
 NUMA node(s):                         1
 Vendor ID:                            GenuineIntel
 CPU family:                           6
 Model:                                85
 Model name:                           Intel(R) Xeon(R) CPU @ 2.00GHz
 Stepping:                             3
 CPU MHz:                              2000.148
 BogoMIPS:                             4000.29
 Hypervisor vendor:                    KVM
 Virtualization type:                  full
 L1d cache:                            64 KiB
 L1i cache:                            64 KiB
 L2 cache:                             2 MiB
 L3 cache:                             38.5 MiB
 NUMA node0 CPU(s):                    0-3
 Vulnerability Gather data sampling:   Not affected
 Vulnerability Itlb multihit:          Not affected
 Vulnerability L1tf:                   Mitigation; PTE Inversion
 Vulnerability Mds:                    Mitigation; Clear CPU buffers; SMT Host state unknown
 Vulnerability Meltdown:               Mitigation; PTI
 Vulnerability Mmio stale data:        Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
 Vulnerability Reg file data sampling: Not affected
 Vulnerability Retbleed:               Mitigation; IBRS
 Vulnerability Spec rstack overflow:   Not affected
 Vulnerability Spec store bypass:      Mitigation; Speculative Store Bypass disabled via prctl and seccomp
 Vulnerability Spectre v1:             Mitigation; usercopy/swapgs barriers and __user pointer sanitization
 Vulnerability Spectre v2:             Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI SW loop, KVM SW loop
 Vulnerability Srbds:                  Not affected
 Vulnerability Tsx async abort:        Mitigation; Clear CPU buffers; SMT Host state unknown
 Flags:                                fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti ssbd ibrs ibpb stibp fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves arat md_clear arch_capabilities
 
 ***CMake***
 /usr/bin/cmake

cmake: /opt/conda/lib/libcurl.so.4: no version information available (required by cmake)
cmake version 3.16.3

 CMake suite maintained and supported by Kitware (kitware.com/cmake).
 
 ***g++***
 /usr/bin/g++
 g++ (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
 Copyright (C) 2019 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
 
 ***nvcc***
 /opt/conda/bin/nvcc
 nvcc: NVIDIA (R) Cuda compiler driver
 Copyright (c) 2005-2023 NVIDIA Corporation
 Built on Mon_Apr__3_17:16:06_PDT_2023
 Cuda compilation tools, release 12.1, V12.1.105
 Build cuda_12.1.r12.1/compiler.32688072_0
 
 ***Python***
 /opt/conda/bin/python
 Python 3.10.13
 
 ***Environment Variables***
 PATH                            : /opt/bin:/opt/conda/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
 LD_LIBRARY_PATH                 : /usr/local/cuda/lib64:/usr/local/cuda/lib:/usr/local/lib/x86_64-linux-gnu:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/usr/local/nvidia/lib:/usr/local/nvidia/lib64:/opt/conda/lib
 NUMBAPRO_NVVM                   :
 NUMBAPRO_LIBDEVICE              :
 CONDA_PREFIX                    :
 PYTHON_PATH                     :
 
 ***conda packages***
 /opt/conda/bin/conda

Additional context

Found via Narwhals

@MarcoGorelli MarcoGorelli added the bug Something isn't working label Oct 2, 2024
@mroeschke mroeschke added the Python Affects Python cuDF API. label Oct 2, 2024
@rapids-bot rapids-bot bot closed this as completed in d15bbfd Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants