Implement scan-based whole-frame aggregations for cudf-polars #16509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
feature request
github-actions
bot
added
Python
lithomas1
requested review from
vyasr and
isVoid
and removed request for
a team
| @@ -26,7 +26,7 @@ def test_translation_assert_raises(): | |||
| class E(Exception): | |||
| pass | |||
|
|
|||
| unsupported = df.group_by("a").agg(pl.col("a").cum_max().alias("b")) | |||
| unsupported = df.group_by("a").agg(pl.col("a").upper_bound().alias("b")) | |||
There was a problem hiding this comment.
This is fine for now since it's already doing this just with another function, but I'll do some thinking about how we can test the IR translation utility without needing to chase an actually unsupported feature
brandon-b-miller
approved these changes
Aug 16, 2024
|
/ok to test |
|
/merge |
rapids-bot
bot
merged commit 152111b
into
rapidsai:feature/cudf-polars
76 of 77 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
contributes to #16478
This implements "cum_min", "cum_max", "cum_prod", "cum_sum"
"cum_count" is not implemented for now, since there's no exact libcudf match (I imagine the non-grouped case is also not used that much but haven't checked).
I suppose we could implement it by creating a column of 1s and copying the null mask over, and doing a cum_sum on that.
Let me know if you want to try that.
Checklist