Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support scan-based aggregations in cudf-polars #16478

Closed
wence- opened this issue Aug 2, 2024 · 1 comment
Closed

[FEA] Support scan-based aggregations in cudf-polars #16478

wence- opened this issue Aug 2, 2024 · 1 comment
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request

Comments

@wence-
Copy link
Contributor

wence- commented Aug 2, 2024

We currently support reduction-based aggregations in both whole-frame and groupby contexts. However, we have not yet implemented scan-based aggregations.

We should implement these. The whole-frame case is probably quite straightforward. For the grouped context, we probably need some libcudf work (see #15541)
@wence- wence- added feature request New feature or request cudf.polars Issues specific to cudf.polars labels Aug 2, 2024
@lithomas1 lithomas1 mentioned this issue Aug 7, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Aug 20, 2024
@lithomas1
Implement scan-based whole-frame aggregations for cudf-polars (#16509)
152111b 
contributes to #16478

This implements "cum_min", "cum_max", "cum_prod", "cum_sum"

"cum_count" is not implemented for now, since there's no exact libcudf match (I imagine the non-grouped case is also not used that much but haven't checked).
I suppose we could implement it by creating a column of 1s and copying the null mask over, and doing a cum_sum on that.
Let me know if you want to try that.

Authors:
  - Thomas Li (https://github.com/lithomas1)

Approvers:
  - https://github.com/brandon-b-miller

URL: #16509
@github-project-automation github-project-automation bot moved this from Todo to Done in cuDF Python Sep 19, 2024
@beckernick
Copy link
Member

beckernick commented Sep 19, 2024 •
edited
Loading

This was implemented for the whole-frame scenario for beta release (except cumulative count, which we can track independently).

Let's track the groupby scans separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wence- @beckernick